Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiply-add interface in LinearAlgebra #29634

Merged
merged 46 commits into from
Aug 14, 2019
Merged

Implement multiply-add interface in LinearAlgebra #29634

merged 46 commits into from
Aug 14, 2019

Commits on Nov 18, 2018

  1. Multiply-add interface for BLAS.gemm!

    @tkf
    tkf committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    9cef41a View commit details
    Browse the repository at this point in the history

  2. Multiply-add interface for BLAS.syrk!

    @tkf
    tkf committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    4013d8d View commit details
    Browse the repository at this point in the history

  3. Multiply-add interface for BLAS.herk!

    @tkf
    tkf committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    93aa9b6 View commit details
    Browse the repository at this point in the history

  4. Multiply-add interface for gemv!

    @tkf
    tkf committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    95deaaf View commit details
    Browse the repository at this point in the history

  5. Fix UndefRefError from C[i,j] 

    It may not be defined for Matrix{BigFloat}.
    @tkf
    tkf committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    302396b View commit details
    Browse the repository at this point in the history

  6. Do not assume *(::Bool, ::eltype(C)) exists

    @tkf
    tkf committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    3b72e3b View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Implement mul! in terms of addmul!

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    a27f5f5 View commit details
    Browse the repository at this point in the history

  2. Test multiply-add interface

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    04333aa View commit details
    Browse the repository at this point in the history

  3. Document addmul!

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    ae38931 View commit details
    Browse the repository at this point in the history

  4. Use lmul! for beta * C; eltype may not be commutative

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    87b41b8 View commit details
    Browse the repository at this point in the history

  5. Add _lmul_or_fill!

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    8f41412 View commit details
    Browse the repository at this point in the history

  6. Add multiply-add interface for symmetric matrices

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    b97af31 View commit details
    Browse the repository at this point in the history

  7. Add multiply-add interface for Number and UniformScaling

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    cd169b3 View commit details
    Browse the repository at this point in the history

  8. Add multiply-add interface for diagonal matrices

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    a655ff8 View commit details
    Browse the repository at this point in the history

  9. Add multiply-add interface for bi- and tri-diagonal matrices

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    84f009b View commit details
    Browse the repository at this point in the history

  10. Add multiply-add interface for triangular matrices

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    b0ab7b2 View commit details
    Browse the repository at this point in the history

  11. Test multiply-add interface in test/generic.jl

    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    92a7e86 View commit details
    Browse the repository at this point in the history

  12. Fix addmul!(C, s::Number, X, alpha, beta) 

    and addmul!(C, X, s::Number, alpha, beta)
    @tkf
    tkf committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    00cfc91 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Special-case alpha=1 beta=0 using type parameter

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    ed6821f View commit details
    Browse the repository at this point in the history

  2. Test multiply-add interface in test/uniformscaling.jl

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    602fb7b View commit details
    Browse the repository at this point in the history

  3. Test multiply-add interface in test/diagonal.jl

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    c33767b View commit details
    Browse the repository at this point in the history

  4. Use addmul! in SparseArrays

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    1309cc7 View commit details
    Browse the repository at this point in the history

  5. Systematically test addmul!

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    4d61edf View commit details
    Browse the repository at this point in the history

  6. Make MulAddMul benchmark-friendly

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    d88a182 View commit details
    Browse the repository at this point in the history

  7. Fix _modify! docstring

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    8957d0b View commit details
    Browse the repository at this point in the history

  8. Use MulAddMul in A_mul_B_td!

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    66e04c7 View commit details
    Browse the repository at this point in the history

  9. Comment out broken test_broken

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    d0a7672 View commit details
    Browse the repository at this point in the history

  10. Relax rtol based on eltype of matrices A, B, C

    @tkf
    tkf committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    96c5550 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Pass around MulAddMul instead of alpha and beta for type stability

    @tkf
    tkf committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    57a6077 View commit details
    Browse the repository at this point in the history

  2. Inline functions between *(::Matrix, ::Matrix) and gemm_wrapper! 

    This is required for recovering the performance of current master.
Checked with:

    A = [1. 0; 2 0]
    @benchmark $A * $A
    @tkf
    tkf committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    46d6614 View commit details
    Browse the repository at this point in the history

  3. Annotate argument type MulAddMul

    @tkf
    tkf committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    b0642c5 View commit details
    Browse the repository at this point in the history

  4. Inline all addmul!

    @tkf
    tkf committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    eb1e87f View commit details
    Browse the repository at this point in the history

  5. Construct MulAddMul outside A_mul_B_td!

    @tkf
    tkf committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    ce7b862 View commit details
    Browse the repository at this point in the history

  6. Add multiply-add interface in test/tridiag.jl

    @tkf
    tkf committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    0a09ec1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2018

  1. Mention combined multiply-add in NEWS.md [ci skip]

    @tkf
    tkf committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    474c9f7 View commit details
    Browse the repository at this point in the history

  2. Mention that mul!(C, A, B, α, β) is deprecated [ci skip]

    @tkf
    tkf committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    82c5749 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Change API definition to C = ABα + Cβ

    @tkf
    tkf committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    29683db View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2018

  1. Fix indentation

    @tkf
    tkf committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    07058ba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into matmuladd

    @tkf
    tkf committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    fae1a7a View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Merge branch 'master' into matmuladd

    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    84b3be7 View commit details
    Browse the repository at this point in the history

  2. Fix triangular.jl

    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    49fed2a View commit details
    Browse the repository at this point in the history

  3. Fix UndefRefError in multiplication with Diagonal

    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    32853b9 View commit details
    Browse the repository at this point in the history

  4. Define Base.convert(::Type{Quaternion{T}}, s::Real) 

    This is required for testset "* and mul! for non-commutative scaling"
in LinearAlgebra/test/generic.jl to pass.
    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    ae925c2 View commit details
    Browse the repository at this point in the history

  5. Rename: addmul! -> mul!

    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    7be001f View commit details
    Browse the repository at this point in the history

  6. Fix doctest

    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    22121d0 View commit details
    Browse the repository at this point in the history

  7. Workaround broadcast error with e.g., triangular matrix of BigFloat

    @tkf
    tkf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    c7e3efd View commit details
    Browse the repository at this point in the history