Fix: Enum values doesn't display UInt8 correctly #29035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello and welcome to Julia. Great first contribution! |
KristofferC
approved these changes
Sep 4, 2018
JeffBezanson
reviewed
Sep 4, 2018
test/enums.jl
Outdated
| @test repr("text/plain", UI8) == "Enum $(string(UI8)):\nten = 0x0a\nthr = 0x03\nsevn = 0x07" | ||
| @enum UI8::UInt8 ten=0x0A thr=0x03 sevn=0x07 fiftn=0xF0 | ||
| @test repr("text/plain", UI8) == "Enum $(string(UI8)):\nten = 0x0a\nthr = 0x03\nsevn = 0x07\nfiftn = 0xf0" | ||
| @test repr("text/plain", ten) == "$(string(ten))::$(string(UI8)) = 0x0a" |
There was a problem hiding this comment.
Looks like this should be just UI8 instead of $(string(UI8)).
There was a problem hiding this comment.
Thanks a lot for the feedback. Fixed
d9dd96f
to
73937d7
Compare
|
Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to learn Julia yesterday but I think that I've fixed #28965 bug
I hope to be useful