Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lit and FileCheck to tools and run llvmpasses by default #28841

Merged
merged 8 commits into from
Sep 1, 2018
Merged

Conversation

vchuravy
Copy link
Sponsor Member

Installing lit is ugly since it comes as a Python package, but imho still better than pointing it into the source-tree.

#28330 and #28838

@vchuravy vchuravy requested review from vtjnash and Keno August 23, 2018 04:38
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Have you checked that everything still works when running the llvmpasses tests with a source build?

deps/llvm.mk Outdated Show resolved Hide resolved
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

deps/llvm.mk Outdated Show resolved Hide resolved
@vchuravy vchuravy changed the title [WIP] Add lit and FileCheck to tools Add lit and FileCheck to tools and run llvmpasses by default Aug 31, 2018
@vchuravy
Copy link
Sponsor Member Author

Now includes #28330 and I fixed a couple of issues that I noted with out-of-tree builds.
LLVMBuilder is ready, LGTM when CI is green.

@vchuravy
Copy link
Sponsor Member Author

vchuravy commented Aug 31, 2018

Ok fixed a problem with the source install of LLVM. In order to test this a make -C deps reinstall-llvm should be sufficient.

@vchuravy
Copy link
Sponsor Member Author

vchuravy commented Sep 1, 2018

CI failure is network

@vchuravy vchuravy merged commit 8acad0c into master Sep 1, 2018
@vchuravy vchuravy deleted the vc/utils branch September 1, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants