Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vec of adjoint vector #28568

Merged
merged 1 commit into from
Aug 12, 2018
Merged

Fix vec of adjoint vector #28568

merged 1 commit into from
Aug 12, 2018

Conversation

andreasnoack
Copy link
Member

Currently, we have that

julia> vec([1 + 1im]') == 1 - 1im
false

This PR fixes it.

@andreasnoack andreasnoack added kind:bug Indicates an unexpected problem or unintended behavior domain:linear algebra Linear algebra kind:bugfix This change fixes an existing bug backport pending 0.7 and removed kind:bug Indicates an unexpected problem or unintended behavior labels Aug 10, 2018
@andreasnoack andreasnoack merged commit 04f4884 into master Aug 12, 2018
@andreasnoack andreasnoack deleted the an/vec branch August 12, 2018 07:44
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@andreasnoack @KristofferC
Fix vec of adjoint vector (#28568)
4dfbcef 
(cherry picked from commit 04f4884)
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@andreasnoack @KristofferC
Fix vec of adjoint vector (#28568)
70f78aa 
(cherry picked from commit 04f4884)
@KristofferC KristofferC mentioned this pull request Aug 19, 2018
Merged
KristofferC pushed a commit that referenced this pull request Aug 19, 2018
@andreasnoack @KristofferC
Fix vec of adjoint vector (#28568)
a04c305 
(cherry picked from commit 04f4884)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@andreasnoack @KristofferC
Fix vec of adjoint vector (#28568)
080ce53 
(cherry picked from commit 04f4884)
KristofferC pushed a commit that referenced this pull request Sep 8, 2018
@andreasnoack @KristofferC
Fix vec of adjoint vector (#28568)
c4c4199 
(cherry picked from commit 04f4884)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@andreasnoack @KristofferC
Fix vec of adjoint vector (#28568)
f4df610 
(cherry picked from commit 04f4884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:linear algebra Linear algebra kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreasnoack @KristofferC