Remove checks in tril, triu, and diag #28480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
domain:linear algebra
|
I assume this can be in 1.0, but is not needed in 0.7? |
ararslan
pushed a commit
that referenced
this pull request
Aug 7, 2018
* Stop throwing for out of bounds diagonals in tril, triu and diag defined in LinearAlgebra * Remove checks from tril, triu and diag in SparseArrays (cherry picked from commit e76b005)
Keno
pushed a commit
that referenced
this pull request
Aug 7, 2018
* Stop throwing for out of bounds diagonals in tril, triu and diag defined in LinearAlgebra * Remove checks from tril, triu and diag in SparseArrays (cherry picked from commit e76b005)
|
This change should be in NEWS |
KristofferC
removed
backport pending 0.7
needs news
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* Stop throwing for out of bounds diagonals in tril, triu and diag defined in LinearAlgebra * Remove checks from tril, triu and diag in SparseArrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16959, we were almost indifferent between making the checks consistent and removing them. We ended up with checks but they have shown up to be problematic. I discussed the issue with @Sacha0 today and we decided that it would be better to remove the checks. Fixes #28447.