Work around invalid register errors with 64-bit Windows #28449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess if/when this is merged, we should undo JuliaCI/julia-buildbot#86? |
staticfloat
approved these changes
Aug 5, 2018
|
Why does the BUILD_OS matter? This flag will possibly make profile broken of blas code, but that’s probably not a big issue. |
The issue seems to be specific to Cygwin, so I figured I'd just apply it to Cygwin.
Interesting. I guess we don't have a test for that? Would it make more sense then to just disable AVX-512 by default for 64-bit Windows (or just Cygwin)? |
Adding `-fno-asynchronous-unwind-tables` to the C compiler flags passed to OpenBLAS works around errors claiming an invalid register for `.seh_savexmm`. We've been running into this on the 64-bit Windows buildbots. See discussion in OpenMathLib/OpenBLAS#1708.
72b4e46
to
23ac667
Compare
|
Changed to be 64-bit Windows more generally, not just Cygwin. |
|
Keno said, "Merge it." |
ararslan
added a commit
that referenced
this pull request
Aug 6, 2018
Adding `-fno-asynchronous-unwind-tables` to the C compiler flags passed to OpenBLAS works around errors claiming an invalid register for `.seh_savexmm`. We've been running into this on the 64-bit Windows buildbots. See discussion in OpenMathLib/OpenBLAS#1708. (cherry picked from commit 651a727)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Adding `-fno-asynchronous-unwind-tables` to the C compiler flags passed to OpenBLAS works around errors claiming an invalid register for `.seh_savexmm`. We've been running into this on the 64-bit Windows buildbots. See discussion in OpenMathLib/OpenBLAS#1708.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
-fno-asynchronous-unwind-tablesto the C compiler flags passed to OpenBLAS works around errors claiming an invalid register for.seh_savexmm. We've been running into this on the 64-bit Windows buildbot.See discussion in OpenMathLib/OpenBLAS#1708.