Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: prettier IR-show for line number and inlining information #28390

Merged
merged 4 commits into from
Sep 10, 2018
Merged

RFC: prettier IR-show for line number and inlining information #28390

merged 4 commits into from
Sep 10, 2018

Commits on Aug 31, 2018

  1. compiler: handle old-form IR in compute_basic_blocks

    @vtjnash
    vtjnash committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    4dd007a View commit details
    Browse the repository at this point in the history

  2. code_llvm annotations: format prettier 

    Use box-drawing characters and indentation to make the output readable more rapidly.
    @vtjnash
    vtjnash committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    ab14126 View commit details
    Browse the repository at this point in the history

  3. code_typed/code_lowered: format line-info similarly to code_llvm/code… 

    …_native

For consistency of user experience, reduce the variance in our IR printing across formats.
This also now shows inlining and line number information even if the output device might not support color,
which was previously impossible (a regression since v0.6).
    @vtjnash
    vtjnash committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    0c7652c View commit details
    Browse the repository at this point in the history

  4. code formatting: reduce inlining indentation 

    Here we make the observation that it's somewhat common to have chains
of methods of one function that recursively handle arguments in some
fashion (for example, map-tuple or +). However, since they all have the
same method name, it's possible to represent these on a single line.
    @vtjnash
    vtjnash committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    1f80e44 View commit details
    Browse the repository at this point in the history