refactor renumber_ir_elements to allow separate ssa and label changemaps #28279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrevels
force-pushed
the
jr/renumberflexible
branch
from
5db8e7a
to
f203871
Compare
jrevels
force-pushed
the
jr/renumberflexible
branch
2 times, most recently
from
4b630dd
to
c4b2b31
Compare
jrevels
force-pushed
the
jr/renumberflexible
branch
from
c4b2b31
to
71b0d89
Compare
|
Will merge tonight assuming no objections |
| end | ||
| end | ||
| changemap[end] != 0 || return | ||
| (labelchangemap[end] != 0 && ssachangemap[end] != 0) || return |
There was a problem hiding this comment.
It seems like this should be || instead of &&?
There was a problem hiding this comment.
Hmmm. AFAIK normal use would imply that if either changemap has nonzero entries, then the other has nonzero entries as well. Otherwise, it seems like you've passed invalid input to this function or are using it to apply an invalid pass.
That's mainly from my own use cases/use cases in Base, though. Maybe there's a use case where you're building up the label changes and SSA changes in separate calls to renumber_ir_elements. Not sure what kind of pass that makes sense for, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors this utility function to be a bit nicer when e.g. you want to decide whether your insertions will occur before or after the insertion point. Also adds a test.