Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More doc touchups and some doctests #28033

Merged
merged 1 commit into from
Jul 11, 2018
Merged

More doc touchups and some doctests #28033

merged 1 commit into from
Jul 11, 2018

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jul 10, 2018

I found these old docstrings very confusing, hopefully they are clearer now.

@kshyatt kshyatt added docs This change adds or pertains to documentation strings "Strings!" labels Jul 10, 2018
@kshyatt
Copy link
Contributor Author

kshyatt commented Jul 11, 2018

Test fail is in download - seems unrelated? Good to go?

@fredrikekre fredrikekre merged commit 426c0ba into master Jul 11, 2018
@fredrikekre fredrikekre deleted the ksh/strtouchup branch July 11, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyatt @KristofferC @fredrikekre