Small doc touchups and doctests for mv #28032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the examples are becoming kinda excessively long (~40 lines). It's a lot of scrolling up in the terminal to get to the actual content. Is it possible to condense things a bit? |
|
I wanted to show all the behavior mentioned in the docstring. I can strip out the parts showing the file content hasn't changed if you'd like. |
KristofferC
reviewed
Jul 10, 2018
base/file.jl
Outdated
| julia> readline("goodbye.txt") | ||
| "world2" | ||
|
|
||
| julia> rm("goodbye.txt") |
base/file.jl
Outdated
| ```jldoctest; filter = r"Stacktrace:(\\n \\[[0-9]+\\].*)*" | ||
| julia> write("hello.txt", "world"); | ||
|
|
||
| julia> "hello.txt" in readdir() |
There was a problem hiding this comment.
Don't think we need to show that write creates the file here.
base/file.jl
Outdated
| julia> mv("hello.txt", "goodbye.txt", force=true) | ||
| "goodbye.txt" | ||
|
|
||
| julia> readline("goodbye.txt") |
There was a problem hiding this comment.
Don't need to show that mv copies content again?
base/file.jl
Outdated
| julia> "hello.txt" in readdir() | ||
| false | ||
|
|
||
| julia> "goodbye.txt" in readdir() |
There was a problem hiding this comment.
Can remove this since the line below shows that the file exist?
|
@KristofferC thanks for the review! Better now? |
KristofferC
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passed doctests locally. All the changes are to the filesystem part of the docs (
@__LINE__is displayed there).