update serializer symbol tables for new IR #27994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Jul 9, 2018
src/common_symbols2.inc
Outdated
| jl_symbol("throw_inexacterror"), | ||
| jl_symbol("UInt64"), | ||
| jl_symbol("/home/jeff/src/julia/usr/share/julia/stdlib/v0.7/LinearAlgebra/src/lapack.jl"), | ||
| jl_symbol("checkbounds"), |
There was a problem hiding this comment.
Should absolute paths be filtered somehow
|
Does this change the Serialization "world"? I.e. Previously serialized julia structures won't be compatible after this change? Sorry for the ignorance if it's not related, but I think it's good to be loud when a change like that happens. |
|
No, this doesn't affect the |
Also de-duplicate symbols via Method.roots in IR compression. Replace gen_sysimg_symtab code with an analysis based on Method.roots lists.
JeffBezanson
force-pushed
the
jb/symtabs07
branch
from
ba99167
to
991296b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been done since the big IR change, so things have drifted pretty far. This shaves ~10MB off the system image.
Also fix deprecation warnings in the generator script.