Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show type information for invalid index error #27837

Merged
merged 1 commit into from
Jun 28, 2018
Merged

show type information for invalid index error #27837

merged 1 commit into from
Jun 28, 2018

Conversation

fredrikekre
Copy link
Member

Changes

julia> [1,][1.0]
ERROR: ArgumentError: invalid index: 1.0

to

julia> [1,][1.0]
ERROR: ArgumentError: invalid index: 1.0 of type Float64

The previous error confused someone on SO; the value 1 is a valid index, the problem here is more about the type of the value so it is good to show that.

@fredrikekre fredrikekre requested a review from mbauman June 28, 2018 07:33
@mbauman mbauman merged commit d196d0f into master Jun 28, 2018
@mbauman mbauman deleted the fe/indextype branch June 28, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants