Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor substitute!, rename it to partially_inline!, and document it #27689

Merged
merged 5 commits into from
Jun 22, 2018

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Jun 20, 2018

This is the kind of function we should eventually have in a "compiler/IR stdlib", but for now we can keep it in Meta.

@jrevels
Copy link
Member Author

jrevels commented Jun 21, 2018

Prior to a rebase, one of the CircleCI builds here passed, while the rest of CI failed with various segfaults. Not sure why, but after rebasing, this passes tests fine on Anubis. Hopefully CI agrees...

@jrevels
Copy link
Member Author

jrevels commented Jun 22, 2018

FreeBSD tests timed out right after the LibGit2 tests.

Travis 64bit Linux tests failed trying to install dependencies:

⋮
W: Failed to fetch http:https://ppa.launchpad.net/git-core/ppa/ubuntu/dists/trusty/main/i18n/Translation-en  Unable to connect to ppa.launchpad.net:http:
W: Failed to fetch http:https://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http:
W: Failed to fetch http:https://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/main/binary-i386/Packages  Unable to connect to ppa.launchpad.net:http:
W: Some index files failed to download. They have been ignored, or old ones used instead.

The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install ccache libssl1.0.0 bar time g++-5 gfortran-5" failed and exited with 100 during .

CircleCI x86_64 failed with:

Killed
*** This error is usually fixed by running `make clean`. If the error persists, try `make cleanall`. ***
Makefile:202: recipe for target '/home/circleci/project/usr/lib/julia/sys-debug-o.a' failed
make[1]: *** [/home/circleci/project/usr/lib/julia/sys-debug-o.a] Error 1
Makefile:81: recipe for target 'julia-sysimg-debug' failed
make: *** [julia-sysimg-debug] Error 2
make: *** Waiting for unfinished jobs....
Killed
*** This error is usually fixed by running `make clean`. If the error persists, try `make cleanall`. ***
Makefile:201: recipe for target '/home/circleci/project/usr/lib/julia/sys-o.a' failed
make[1]: *** [/home/circleci/project/usr/lib/julia/sys-o.a] Error 1
Makefile:78: recipe for target 'julia-sysimg-release' failed
make: *** [julia-sysimg-release] Error 2
Exited with code 2

All the other builds passed. I don't think these failures are relevant, but I'll request review before merging.

@jrevels jrevels requested a review from vtjnash June 22, 2018 11:57
@jrevels jrevels merged commit b845695 into master Jun 22, 2018
@jrevels jrevels deleted the jr/partialinlinemeta branch June 22, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants