Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up jl_box_ functions #27673

Merged
merged 1 commit into from
Jun 20, 2018
Merged

clean up jl_box_ functions #27673

merged 1 commit into from
Jun 20, 2018

Conversation

JeffBezanson
Copy link
Sponsor Member

  • remove some unused ones
  • set sign extension attributes more accurately
  • tell codegen that box_int8 and box_uint8 return rooted values

@JeffBezanson
clean up jl_box_ functions
01c291c 
- remove some unused ones
- set sign extension attributes more accurately
- tell codegen that box_int8 and box_uint8 return rooted values
vtjnash
vtjnash approved these changes Jun 19, 2018
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JeffBezanson JeffBezanson merged commit 43f66e2 into master Jun 20, 2018
@JeffBezanson JeffBezanson deleted the jb/boxfuncs branch June 20, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffBezanson @vtjnash @Keno