Added kron for Diagonal matrices #27581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebej
commented
Jun 14, 2018
stdlib/LinearAlgebra/src/diagonal.jl
Outdated
| function kron(A::Diagonal{T1}, B::Diagonal{T2}) where {T1<:Number, T2<:Number} | ||
| valA = A.diag; nA = length(valA) | ||
| valB = B.diag; nB = length(valB) | ||
| valC = Vector{typeof(zero(T1)*zero(T2))}(nA*nB) |
|
This is ready to be merged, although it could wait after 0.7 since it's not a breaking change (unless someone was relying on the fact that this used to return an |
|
No harm merging once it passes tests by the same token—it doesn't break anything and it's uncontroversial, so why not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.