Fix inlining of exception handlers #27502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually exception handlers immediately disqualify a function for inlining, which is why we did not see this before. However, that can of course be overriden with `@inline`. In the CFG, we use `0` as a virtual predecessor, to the catch block, in order to force all values to go through the PhiC mechanism. We need to avoid trying to rename this virtual predecessor. Fixes #27456
|
Can't check right now (on the phone), but does the test actually fail without the fix? Or does it print the error but then pass nonetheless? |
|
Prints the error, but I think we'd notice if the test started barfing error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually exception handlers immediately disqualify a function for inlining,
which is why we did not see this before. However, that can of course be
overriden with
@inline. In the CFG, we use0as a virtual predecessor,to the catch block, in order to force all values to go through the PhiC
mechanism. We need to avoid trying to rename this virtual predecessor.
Fixes #27456