move [l]gamma, [l]beta and lfact to SpecialFunctions.jl #27473
Conversation
fredrikekre
added
domain:maths
| @deprecate_moved lbeta "SpecialFunctions" | ||
| @deprecate_moved lfact "SpecialFunctions" | ||
| function factorial(x::Number) | ||
| error("""factorial(x::Number) has been moved to the package SpecialFunctions.jl. |
There was a problem hiding this comment.
This doesn't make sense to me. Why would we move one method and not the whole function? With this, SpecialFunctions will need to commit type piracy to define that method.
There was a problem hiding this comment.
Right; https://github.com/JuliaMath/SpecialFunctions.jl/pull/92/files#diff-f839a13f2df5472f7fd840f52ce84e16R757
Do we care though? It's not like SpecialFunctions define this function for a more narrow type, so this could not possibly break anything, since before using SpecialFunctions something like factorial(2.5) would be an error, and behaviour of factorial(::Integer) does not change when loading SpecialFunctions.
There was a problem hiding this comment.
Seems fine to me. This allows people to do using SpecialFunctions in the same REPL session and have it work, which seems far superior to not being able to do so.
fix #27459