Check whether all fields of a mutable struct are defined before SROA #27409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Jun 4, 2018
test/core.jl
Outdated
| @@ -6156,6 +6156,19 @@ struct T27269{X, Y <: Vector{X}} | |||
| end | |||
| @test T27269([[1]]) isa T27269{Int, Vector{Int}} | |||
|
|
|||
| # issue #27365 | |||
| mutable struct foo27365 | |||
| x::Float64 | |||
ararslan
reviewed
Jun 4, 2018
| for (fidx, du) in pairs(fielddefuse) | ||
| isempty(du.uses) && continue | ||
| if fidx + 1 > length(defexpr.args) | ||
| ok = false |
There was a problem hiding this comment.
I think this now requires a global annotation to avoid a deprecation warning. EDIT: Never mind, that's at the top level, this is in a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, just bail out in this situation. There's a number of better
things we could do here. However, I want to avoid making #26764 worse
for now.
Fixes #27365