Update mac travis configuration to only pick specific brew packages #27334
Conversation
.travis.yml
Outdated
| @@ -84,8 +84,7 @@ before_install: | |||
| contrib/travis_fastfail.sh || exit 1; | |||
| brew tap staticfloat/julia; | |||
There was a problem hiding this comment.
Can we throw a > /dev/null on this line while we're at it? It spews thousands of lines of available packages.
There was a problem hiding this comment.
Reverted as Elliot asked.
.travis.yml
Outdated
| @@ -84,8 +84,7 @@ before_install: | |||
| contrib/travis_fastfail.sh || exit 1; | |||
| brew tap staticfloat/julia; | |||
| brew rm --force $(brew deps --HEAD julia); | |||
| brew install -v --only-dependencies --HEAD julia; | |||
| brew install -v staticfloat/juliadeps/libgfortran; | |||
| brew install -v gcc gmp mpfr pcre2 cmake staticfloat/julia/openblas-julia staticfloat/julia/arpack-julia staticfloat/julia/suite-sparse-julia staticfloat/juliadeps/libgfortran; | |||
There was a problem hiding this comment.
We don't need staticfloat/juliadeps/libgfortran since we're installing gcc. I don't know why that was on the previous line, but we should get rid of it.
| @@ -82,7 +82,7 @@ before_install: | |||
| export PATH="$(brew --prefix ccache)/libexec:$PATH"; | |||
| BAR="pv -i 30"; | |||
| contrib/travis_fastfail.sh || exit 1; | |||
| brew tap staticfloat/julia; | |||
| brew tap staticfloat/julia > /dev/null; | |||
There was a problem hiding this comment.
I don't think we should > /dev/null here; this means we won't catch errors like what brought us to this PR in the first place. Travis auto-collapses the brew installation section anyway, since it's not in the main testing script section.
There was a problem hiding this comment.
This is just on adding the tap, not actually installing the dependencies. Even though travis collapses it, it does so via some shoddy Javascript that turns my poor old computer into a heater.
|
I've killed everything but the mac CI. |
|
My bad, Matt is correct, that was only on tapping, not actually installing from the tap. Sorry. He's right, it should be an improvement to pipe it away. The Mac Julia build has made it to bootstrap, which means that this monkeying around hasn't impacted anything of importance; so once you re-introduce the |
|
Yeah, it's running tests so we are good. I am introducing it back, and merging this. |
No description provided.