Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase challenge_prompt timeout to 60 seconds #27329

Merged
merged 1 commit into from
May 30, 2018

Conversation

omus
Copy link
Member

@omus omus commented May 30, 2018

Change will possibly help with LibGit2 test failures which are occurring on the build bots (#27287).

Change will possibly help with LibGit2 test failures which are occurring
on the build bots.
@ararslan ararslan added test This change adds or pertains to unit tests libgit2 The libgit2 library or the LibGit2 stdlib module labels May 30, 2018
@mbauman
Copy link
Member

mbauman commented May 30, 2018

You're too fast! I have SSH'ed into the buildbots earlier and have been running the LibGit2 tests on the Mac buildbot with a longer timeout (I had chosen 30 seconds). That represents a hard case and I've not seen any failures yet.

Let's do this.

@mbauman
Copy link
Member

mbauman commented May 30, 2018

Just as further confirmation that this is the right thing to do: I added debugging statements to look at how long the process waited on the mac buildbot. It's typically 6-8 seconds, but the occasional outlier at 11 or 12 seconds is what's been causing this to crash. With 40 or 50 challenge/response tests, it's not uncommon to hit an outlier over 10 seconds.

@omus
Copy link
Member Author

omus commented May 30, 2018

@mbauman thanks for providing some empirical evidence :). The primary reason the timeout was set to a low value of 10 seconds was to avoid wasting CI time. When an unexpected prompt would appear we would need to wait for the entire timeout. If this occurs for most of the challenge prompt tests it can slow things down considerably.

@ViralBShah ViralBShah merged commit d3c99a7 into master May 30, 2018
@mbauman mbauman deleted the cv/challenge_prompt-timeout branch May 30, 2018 18:54
@ViralBShah
Copy link
Member

Killing the CI here, and will soon test this with the 0.7-alpha PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants