Some doctests for Sockets #27301
Merged
Some doctests for Sockets #27301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
May 29, 2018
stdlib/Sockets/src/addrinfo.jl
Outdated
| ```jldoctest | ||
| julia> getalladdrinfo("google.com") | ||
| 2-element Array{IPAddr,1}: | ||
| ip"172.217.6.174" |
There was a problem hiding this comment.
google has a lot of IP addresses. dig / host / nslookup seem to bounce between at least 2 or 3 for me over a a short time window. Perhaps a subdomain (like ns1.google.com) or a smaller site / one that we control might be a reliable enough choice?
julia> getalladdrinfo("julialang.org")
8-element Array{Sockets.IPAddr,1}:
ip"151.101.194.49"
ip"151.101.130.49"
ip"151.101.66.49"
ip"151.101.2.49"
ip"2a04:4e42::561"
ip"2a04:4e42:400::561"
ip"2a04:4e42:600::561"
ip"2a04:4e42:200::561"
|
Unfortunate that this makes the doctesting require internet access IMO (or do we have doctests that require that already? I don't think so). Perhaps better make them all |
|
Yeah |
|
Is this ok to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure about the local machine's IP address being the same for the buildbots or CI so that's why it's
julia-repl.