ssair: remove many unnecessary method allocations #27299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inference / optimization needs to be more careful than other code, and the new ssair code has not been careful to follow best-practices for this code and avoid dynamic code patterns (and instead writing "C-like" code as much as reasonable)
Keno
reviewed
May 29, 2018
| @@ -6610,6 +6615,9 @@ static std::unique_ptr<Module> emit_function( | |||
| } | |||
| if (!jl_is_uniontype(phiType) || !TindexN) { | |||
| if (VN) { | |||
| // XXX: this code assumes that `val` is of type `phiType` statically, | |||
There was a problem hiding this comment.
As I mentioned in person, I do want this invariant to hold statically. I'm working on a PR to add that to the verifier and fix the cases that currently violate it.
There was a problem hiding this comment.
Perhaps. Currently the type-system is incapable of maintaining your desired invariant however (it's most common to observe this during IPO transforms such as inlining, although rare to come across such an example and thus not simple to construct from first principles a reliable example).
Keno
approved these changes
May 29, 2018
|
Great to see compile time performance being reclaimed on top of the new optimizer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inference / optimization needs to be more careful than other code,
and the new ssair code has not been careful to follow best-practices for
this code and avoid dynamic code patterns
(and instead writing "C-like" code as much as reasonable)