rm newline from end of Markdown text/plain output #27128
Conversation
| @@ -9,24 +9,26 @@ function term(io::IO, content::Vector, cols) | |||
| isempty(content) && return | |||
| for md in content[1:end-1] | |||
| term(io, md, cols) | |||
| println(io) | |||
| print(io, '\n', '\n') | |||
There was a problem hiding this comment.
Why two newllines?
There was a problem hiding this comment.
Oh I see --- because each element used to end with a newline, but those are now removed?
| println(io) | ||
| join(io, ["–"^ansi_length(cells[i][j]) for j = 1:length(cells[1])], " ") |
There was a problem hiding this comment.
Would it be worth using '-' here as you've done in other places instead of "-"?
There was a problem hiding this comment.
Probably. There is a lot of this idiom in the Markdown module, however, and my inclination would be to leave it to a separate PR to audit the Markdown code for unnecessary 1-character strings.
There was a problem hiding this comment.
That would be fine, but I don't think 1-character strings are really so bad.
There was a problem hiding this comment.
Yes, they are a lot cheaper than a couple of versions ago. And Markdown rendering is not generally performance-critical.
Fixes #27102.
Since I was going through Markdown/render.jl line by line, I also made a few other small cleanups, primarily replacing single-character strings with chars.