Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs example in Functions/Arg destructuring #27014

Merged
merged 1 commit into from
May 1, 2020
Merged

Update docs example in Functions/Arg destructuring #27014

merged 1 commit into from
May 1, 2020

Conversation

cormullion
Copy link
Contributor

The example in Argument destructuring didn't work when I typed it in, so I changed the name to gap().

The example in Argument destructuring didn't work when I typed it in, so I changed the name to `gap()`.
@ararslan ararslan added the domain:docs This change adds or pertains to documentation label May 7, 2018
@JeffBezanson
Copy link
Sponsor Member

I assume you got the error "range must be imported to be extended"? I guess this change is fine, but surely there are other cases where we use Base function names in the manual like this (including minmax just above) so I'm not sure it's really worth fixing.

@ViralBShah
Copy link
Member

It doesn't work as is because:

julia> range((min,max)) = max-min
ERROR: error in method definition: function Base.range must be explicitly imported to be extended

@ViralBShah ViralBShah merged commit c466e8a into JuliaLang:master May 1, 2020
@ViralBShah
Copy link
Member

I guess this is the sort of thing that should become a jldoctest.

@JeffBezanson
Copy link
Sponsor Member

This has whitespace errors, as the CI failures clearly indicated. Build broken.

@ViralBShah
Copy link
Member

ViralBShah commented May 1, 2020

Fixed in e58c6e6

ViralBShah pushed a commit that referenced this pull request May 1, 2020
@ViralBShah
Copy link
Member

I had forgotten this whitespace check inside the old CI bots - since we have a separate CI job for whitespace nowadays. Will look inside these for the old PRs.

@Keno
Copy link
Member

Keno commented May 1, 2020

If something is more than a few weeks old, please always do a new CI run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants