Separate LibGit2.(count|map) from Base.(count|map) #26973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
libgit2
This was referenced May 5, 2018
|
Will merge tomorrow unless someone objects or beats me to it. |
|
I think this PR is incorrect. These functions do indeed follow the contract of the generic function (with the exception of the GitWalker map function which takes extra keyword arguments). In fact in #25261 I deleted one of the map methods after fixing the iterator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already done for
LibGit2.merge!(#24818) andLibGit2.push!(#24837). As an extra bonus this fixes some link problems in the doc generation.ATM this also includes #26971 since otherwise we don't run LibGit2 tests on CI, things passes locally so should be fine.