Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable lazy fused broadcasting in pure Julia #26891

Merged
merged 7 commits into from
Apr 26, 2018
Merged

Customizable lazy fused broadcasting in pure Julia #26891

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dbe1ae0
Customizable lazy fused broadcasting in pure Julia
mbauman Apr 23, 2018
c9a0a41
Rename Broadcast.make to Broadcast.broadcasted
mbauman Apr 24, 2018
4cd10d3
Test and fix #26127
mbauman Apr 24, 2018
8a2d88a
Remove hack that avoided materialize in fallback broadcast
mbauman Apr 24, 2018
75798f9
Remove the last of the base broadcast methods...
mbauman Apr 25, 2018
edd4dcf
Correct NEWS.md
mbauman Apr 25, 2018
18ad6a8
Change lowering of `A .= x` to match fused RHS cases
mbauman Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct NEWS.md
  • Loading branch information
@mbauman
mbauman committed Apr 25, 2018
commit edd4dcf7210b5378182a8b3d8faa23417b55bc0a
9 changes: 5 additions & 4 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,12 @@ This section lists changes that do not have deprecation warnings.
now returns cartesian indices for multidimensional arrays (see below, [#25532]).

* Broadcasting operations are no longer fused into a single operation by Julia's parser.
Instead, a lazy `Broadcasted` wrapper is created, and the parser will call
`copy(bc::Broadcasted)` or `copyto!(dest, bc::Broadcasted)`
Instead, a lazy `Broadcasted` object is created to represent the fused expression and
then realized with `copy(bc::Broadcasted)` or `copyto!(dest, bc::Broadcasted)`
to evaluate the wrapper. Consequently, package authors generally need to specialize
`copy` and `copyto!` methods rather than `broadcast` and `broadcast!`.
See the [Interfaces chapter](https://docs.julialang.org/en/latest/manual/interfaces/#Interfaces-1)
`copy` and `copyto!` methods rather than `broadcast` and `broadcast!`. This also allows
for more customization and control of fused broadcasts. See the
[Interfaces chapter](https://docs.julialang.org/en/latest/manual/interfaces/#man-interfaces-broadcasting-1)
for more information.

* `find` has been renamed to `findall`. `findall`, `findfirst`, `findlast`, `findnext`
Expand Down