Support reshaping custom 0-dimensional arrays #26870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
added
domain:arrays
mbauman
commented
Apr 20, 2018
base/iterators.jl
Outdated
| @@ -1077,6 +1077,7 @@ else | |||
| # fixpoint. | |||
| function fixpoint_iter_type(itrT::Type, valT::Type, stateT::Type) | |||
| nextvalstate = Base._return_type(next, Tuple{itrT, stateT}) | |||
| nextvalstate === Union{} && return Any | |||
There was a problem hiding this comment.
Cc @Keno — I coupled this change here. The failure mode is join((), ","), which attempts to find the value type of next((), start(())) — that's an error and will always be Union{}. I'm assuming that a case like this was intended to be caught by the next line, but of course the bottom type is a subtype of everything so it flies on by and throws an error later. Would it be better to return Any or Union{} in this case?
There was a problem hiding this comment.
My stab in the dark here didn't work. I've just marked things as @test_broken and opened #26871.
StefanKarpinski
approved these changes
Apr 21, 2018
mbauman
added a commit
that referenced
this pull request
Apr 23, 2018
* origin/master: (23 commits) fix deprecations of \cdot and \times (#26884) Support reshaping custom 0-dimensional arrays (#26870) fix some cases of dot syntax lowering (#26878) Pkg3: deterministically close the LibGit2 repo in tests (#26883) code loading docs: add missing graph edge (#26874) add news for #26858 and #26859 [ci skip] (#26869) Deprecate using && and || within at-dot expressions (#26792) widen `Int8` and `Int16` to `Int` instead of `Int32` (#26859) fix #26038, make `isequal` consistent with `hash` for `Ptr` (#26858) Deprecate variadic size(A, dim1, dim2, dims...) method (#26862) add using Random to example in manual (#26864) warn once instead of depwarn since we want to test it Revert "reserve syntax that could be used for computed field types (#18466) (#26816)" (#26857) Fix compilation on LLVM 6.0 change promotion behaviour of `cumsum` and `cumsum!` to match `sum` [LLVM 6] add patch to diamond if-conversion add a precompile command that can be used to precompile all dependencies (#254) use registry if no version entry exist in project for developed pacakges make Pkg3 work as a drop in for the old CI scripts update registries when adding (#253) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26163.