change dim arguments for diff and unique to keyword args
#26776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
domain:arrays
ararslan
approved these changes
Apr 10, 2018
mbauman
reviewed
Apr 10, 2018
base/multidimensional.jl
Outdated
| if dims === (:) | ||
| return invoke(unique, Tuple{Any}, A) | ||
| end | ||
| dim = dims |
There was a problem hiding this comment.
I don't think this will work — you're in a @generated function here.
There was a problem hiding this comment.
Oops, thanks.
JeffBezanson
force-pushed
the
jb/moredimargs
branch
from
1447096
to
2fa0cbd
Compare
|
Looks like you'll need --- a/stdlib/LinearAlgebra/test/lapack.jl
+++ b/stdlib/LinearAlgebra/test/lapack.jl
@@ -202,7 +202,7 @@ end
Bvs = eigvecs(B)
Avs = eigvecs(A)
Bvs = LAPACK.gebak!('S','R',ilo,ihi,scale,Bvs)
- @test norm(diff(Avs ./ Bvs, 1)) < 100 * eps(abs(float(one(elty))))
+ @test norm(diff(Avs ./ Bvs, dims=1)) < 100 * eps(abs(float(one(elty))))
end
end |
JeffBezanson
force-pushed
the
jb/moredimargs
branch
from
2fa0cbd
to
3edcf40
Compare
|
This is introducing a warning during the build:
Aside from that, a summary of the CI failures:
|
JeffBezanson
force-pushed
the
jb/moredimargs
branch
from
3edcf40
to
3fef94a
Compare
ararslan
approved these changes
Apr 12, 2018
StefanKarpinski
removed
the
status:triage
mbauman
added a commit
that referenced
this pull request
Apr 12, 2018
* origin/master: A few more #26670 fixes (#26773) Revert "deprecate using the value of `.=`. fixes #25954" (#26754) change dim arguments for `diff` and `unique` to keyword args (#26776) reorder pmap arguments to allow do-block syntax (#26783) correct deprecated parametric method syntax (#26789) [NewOptimizer] handle new IR nodes correctly in binary format [NewOptimizer] support line number emission from new IR format fix #26453, require obviously-concrete lower bound for a var to be diagonal (#26567) fix #26743, spurious `return` path in try-finally in tail position (#26753) Also lift SelectInst addrspaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to have missed these somehow.