[NewOptimizer] Handle exceptions in new IR #26726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Apr 5, 2018
base/boot.jl
Outdated
| @@ -152,6 +160,7 @@ export | |||
| UndefKeywordError, | |||
| # AST representation | |||
| Expr, QuoteNode, LineNumberNode, GlobalRef, PiNode, PhiNode, | |||
| PhiCNode, UpsilonNode, LineInfoNode, | |||
There was a problem hiding this comment.
The new node types shouldn't be exported from Core, but from Core.IR instead.
Now that the optimizer is complete, we need to start looking at latency. The biggest problem at the moment is that we keep converting back and forth to the legacy IR format. In order to cease doing so, we need to move the other parts of the optimizer that still operate on the old data structure to operate on the new ones instead. This PR does so for inlining. Current status: Boostraps.
```
julia> iterate(t::Tuple, i=1) = (i > length(t) ? nothing : (t[i], i+1))
julia> function any_iterate(f, y)
st = iterate(y)
while !(st === nothing)
f(st[1]) && return true
st = iterate(y, st[2])
end
return false
end
julia> code_typed(any_iterate, typeof((x -> :c == x, (:a, :b))))
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch that merges together all the WIP on the new optimizer, which includes a bunch of bugfixes as well as proper handling of exceptions. There's more work to be done, but we want to get this on master (disabled still), to have a common base on which to rebase all the other WIP and to avoid having as frequent rebase errors.