Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine signif into round, use keyword args for digits/sigdigits #26670

Merged
merged 20 commits into from
Apr 6, 2018
Merged

Combine signif into round, use keyword args for digits/sigdigits #26670

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c6ba0e9
change combine signif into round
simonbyrne Mar 30, 2018
281c550
deprecate signif, move round digits/sigdigits to kwargs
simonbyrne Mar 30, 2018
29eedee
fix bootsrapping
simonbyrne Mar 30, 2018
d5d843b
rejig to get building
simonbyrne Mar 30, 2018
3ffc946
modify tests
simonbyrne Mar 30, 2018
247e1fd
Merge branch 'sb/signif' of https://github.com/JuliaLang/julia into s…
simonbyrne Mar 30, 2018
3346e2a
remove whitespace
simonbyrne Mar 30, 2018
7ed448b
fix tests
simonbyrne Mar 31, 2018
aec787e
Float16 ambiguity problems
simonbyrne Apr 1, 2018
f9337f6
fix complex
simonbyrne Apr 3, 2018
793de08
hopefully fix date warnings
simonbyrne Apr 3, 2018
52e26b3
Merge branch 'master' into sb/signif
simonbyrne Apr 3, 2018
05a4f9b
fix bootstrapping issue
simonbyrne Apr 3, 2018
d073fd3
tweak docs, fix namedtuple test
simonbyrne Apr 4, 2018
2418c85
fix typo
simonbyrne Apr 4, 2018
a89385f
fix a few more errors
simonbyrne Apr 4, 2018
d054dfc
remove troublesome precompile
simonbyrne Apr 4, 2018
baedebb
fix round call
simonbyrne Apr 4, 2018
03ed3fa
more fixes
simonbyrne Apr 4, 2018
a6dd6a4
add NEWS item
simonbyrne Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove whitespace
  • Loading branch information
@simonbyrne
simonbyrne committed Mar 30, 2018
commit 3346e2af6863acf6fb8163483ba7a2d7a19fc233
2 changes: 1 addition & 1 deletion base/floatfuncs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function _round(x, r::RoundingMode, digits::Integer, sigdigits::Nothing, base)
isc = oftype(fx, base)^-digits
r = round(fx / isc, r) * isc
end

if !isfinite(r)
if digits > 0
return fx
Expand Down