reuse wrapper functions rather than ccalling directly to jl_array_del_*/jl_array_grow_* #26667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_*/jl_array_grow_*
|
Probably just historical—I think these calls probably existed before those wrappers did. |
ararslan
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might've been a reason that these wrappers weren't being reused - apologies if that's the case and I missed something.
If I can assume that Base code reliably uses these wrappers as the entry point to
jl_array_del_*/jl_array_grow_*, Cassette's metadata propagation framework doesn't have to do as much foreigncall interception (it redirects certain array primitives called onCassette.Box{<:Array}values). That might not be a tenable assumption though...