Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove repackaging SuiteSparse script. It is no longer needed." #26500

Merged
merged 1 commit into from
Mar 18, 2018

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Mar 17, 2018

This reverts commit 1b09984. This script is used by Travis, which is causing #26499. Fixes #26499.

This reverts commit 1b09984.
This script is used by Travis.
@ararslan ararslan added building Build system, or building Julia or its dependencies system:mac Affects only macOS labels Mar 17, 2018
@vchuravy
Copy link
Member

vchuravy commented Mar 17, 2018

We should turn on "requiring PR", since we never should directly push to master.

@ararslan
Copy link
Member Author

I didn't think that setting existed, otherwise we probably would have already enabled it. If it does though then 💯 for enabling it.

@vchuravy
Copy link
Member

The closest option is called

Require pull request reviews before merging
When enabled, all commits must be made to a non-protected branch and submitted via a pull request with the required number of approving reviews and no changes requested before it can be merged into master.

@ararslan
Copy link
Member Author

The Windows failures are timeouts. The macOS failure is that LibGit2 failed to resolve github.com which is weird, so I restarted it.

@ararslan
Copy link
Member Author

The Mac build will take a while; looks like it's recompiling SuiteSparse from source.

@ararslan
Copy link
Member Author

Okay, the Mac build timed out at 3 hours. @staticfloat, do you know what to do in this situation, where we need to recompile a binary dependency but trying to do it hits the job time limit?

@KristofferC
Copy link
Sponsor Member

Requiring a pr is a good idea but not if it forces a review approved.

@bramtayl
Copy link
Contributor

Maybe add some comments about why this is needed so it doesn't get deleted again?

@nalimilan
Copy link
Member

Also the mention of the script in README could have to be reintroduced: #26432 (comment)

@ViralBShah
Copy link
Member

We still don't want people to use this script in their own builds or depend upon it. It should not be mentioned in the Readme. The purpose should remain only for Mac Travis builds.

@vchuravy
Copy link
Member

The Mac OS build bot timed out because it failed to download GCC

==> Installing staticfloat/julia/julia dependency: gcc
==> Downloading https://homebrew.bintray.com/bottles/gcc-7.3.0_1.el_capitan.bottle.tar.gz
/usr/bin/curl --show-error --user-agent Homebrew/1.5.10 (Macintosh; Intel Mac OS X 10.11.6) curl/7.43.0 --fail --silent --location --remote-time --continue-at - --output /Users/travis/Library/Caches/Homebrew/gcc-7.3.0_1.el_capitan.bottle.tar.gz.incomplete https://homebrew.bintray.com/bottles/gcc-7.3.0_1.el_capitan.bottle.tar.gz
curl: (56) SSLRead() return error -9806
Error: Failed to download resource "gcc"
Download failed: https://homebrew.bintray.com/bottles/gcc-7.3.0_1.el_capitan.bottle.tar.gz

I just kicked it off again hoping that it is a network fluke.

@vchuravy vchuravy merged commit ed37984 into master Mar 18, 2018
@vchuravy vchuravy deleted the aa/revert-remove-repackage branch March 18, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants