Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bunch kaufman type stability #26375

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Fix bunch kaufman type stability #26375

merged 2 commits into from
Mar 9, 2018

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Mar 8, 2018

The info code was missing in the case n = 0.

using LinearAlgebra
A = rand(10, 10)
A += A' + 10 * I
@benchmark bkfact!(S) setup = (S = Symmetric($A, :U))

Now: 2.026 μs (5 allocations: 5.39 KiB)
Earlier: 3.419 μs (8 allocations: 5.48 KiB)

Sacha0
Sacha0 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Harmen! :)

@haampie haampie mentioned this pull request Mar 8, 2018
Closed
@ararslan ararslan added the domain:linear algebra Linear algebra label Mar 8, 2018
@haampie haampie force-pushed the fix-bunch-kaufman-type-stability branch from cfac486 to 7e137c0 Compare March 9, 2018 07:50
@andreasnoack andreasnoack merged commit 4181aad into JuliaLang:master Mar 9, 2018
@KristofferC
Copy link
Sponsor Member

I'm surprised the overhead is so large.

@haampie haampie deleted the fix-bunch-kaufman-type-stability branch March 21, 2018 12:26
ararslan pushed a commit that referenced this pull request Apr 26, 2018
@haampie @ararslan
Fix bunch kaufman type stability (#26375)
d19175b 
* Fix type instability in return type of sytrf functions

* Add test for 0x0 case

Ref #26375
(cherry picked from commit 4181aad)
ararslan pushed a commit that referenced this pull request Apr 26, 2018
@haampie @ararslan
Fix bunch kaufman type stability (#26375)
accb624 
* Fix type instability in return type of sytrf functions

* Add test for 0x0 case

Ref #26375
(cherry picked from commit 4181aad)
ararslan pushed a commit that referenced this pull request May 8, 2018
@haampie @ararslan
Fix bunch kaufman type stability (#26375)
04f788b 
* Fix type instability in return type of sytrf functions

* Add test for 0x0 case

Ref #26375
(cherry picked from commit 4181aad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haampie @KristofferC @Sacha0 @fredrikekre @andreasnoack @ararslan