Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fetch/wait on Task more like Future/RemoteChannel #25940

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

iamed2
Copy link
Contributor

@iamed2 iamed2 commented Feb 8, 2018

This implements #25928

@ararslan ararslan added the domain:parallelism Parallel or distributed computation label Feb 8, 2018
@iamed2
Copy link
Contributor Author

iamed2 commented Feb 8, 2018

There were some uses of wait that I didn't catch when running tests locally; I just need to fix those.

@JeffBezanson JeffBezanson added this to the 1.0 milestone Feb 8, 2018
@iamed2
Copy link
Contributor Author

iamed2 commented Feb 8, 2018

I can fix all of these but it would be nice to know why this happens:

      From worker 9:	ERROR (unhandled task failure): `wait(t::Task)` is deprecated, use `fetch(t)` instead.
      From worker 9:	Stacktrace:
      From worker 9:	 [1] depwarn(::String, ::Symbol) at ./deprecated.jl:68
      From worker 9:	 [2] wait(::Task) at ./deprecated.jl:56
      From worker 9:	 [3] macro expansion at /tmp/julia/share/julia/test/socket.jl:242 [inlined]
      From worker 9:	 [4] (::getfield(Main.Test71Main_socket, Symbol("##13#17")))() at ./task.jl:343

Deprecations shouldn't cause failures, right?

Never mind, found --depwarn=error

@JeffBezanson
Copy link
Sponsor Member

Looks like there is one more use to update in examples/embedding/embedding-test.jl.

@JeffBezanson JeffBezanson merged commit 94197a4 into JuliaLang:master Feb 9, 2018
@iamed2 iamed2 deleted the task-fetch branch February 9, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:parallelism Parallel or distributed computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants