Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude more CI files from source distro #25906

Merged
merged 2 commits into from
Feb 27, 2018
Merged

exclude more CI files from source distro #25906

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f34b534
exclude more CI files from source distro
simonbyrne Feb 6, 2018
08501ed
Exclude any file starting with a .
simonbyrne Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ endif

# Create file light-source-dist.tmp to hold all the filenames that go into the tarball
echo "base/version_git.jl" > light-source-dist.tmp
git ls-files | sed -e '/\.git/d' -e '/\.travis/d' >> light-source-dist.tmp
git ls-files | sed -e '/\.git/d' -e '/\.travis/d' -e '/appveyor.yml/d' -e '/\.circleci/d' -e '/\.freebsdci/d' -e '/\.mailmap/d' >> light-source-dist.tmp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably just exclude everything that starts with ., which will also get the .github folder, then we just need to add the AppVeyor config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea how to write that?

Copy link
Member

@ararslan ararslan Feb 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ummmm sed -e '/\.\*/d' -e '/appveyor.yml/d'? Edit: That does not work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

git ls-files | sed -e '/^\..*/d' -e '/appveyor.yml/d'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iblis17 any particular reason to use .* instead of .+? If not, I'd suggest the latter for extra clarity (we don't mean to capture ".")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does OSX have gsed ? or I can write one for bsd sed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no gsed, it uses BSD sed.

Copy link
Member

@iblislin iblislin Feb 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for bsd sed

git ls-files | sed -E -e '/^\..+/d' -e '/\/\..+/d' -e '/appveyor.yml/d'

I test it on my FreeBSD box

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that works! Is that compatible with GNU sed as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on an Arch box, seems work.

find doc/_build/html >> light-source-dist.tmp

# Make tarball with only Julia code
Expand Down