Deprecate print_shortest #25863
Merged
Deprecate print_shortest #25863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates `print_shortest` to `Base.Grisu.print_shortest`. The only place where `print_shortest` is used is in DelimitedFiles, when writing numeric values. This has been changed to `print`, which is technically a breaking change, though it more accurately represents the value being written. Fixes #25745.
ararslan
added
kind:breaking
StefanKarpinski
approved these changes
Feb 2, 2018
|
Circle i686 failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates
print_shortesttoBase.Grisu.print_shortest.The only place where
print_shortestis used is in DelimitedFiles, when writing numeric values. This has been changed toprint, which is technically a breaking change, though it more accurately represents the value being written.Fixes #25745.