exclude delimiter by default in readuntil; rename chomp option to keep
#25646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
kind:breaking
JeffBezanson
force-pushed
the
jb/readuntilchomp
branch
from
c9d0053
to
c5aaed7
Compare
StefanKarpinski
approved these changes
Jan 20, 2018
JeffBezanson
force-pushed
the
jb/readuntilchomp
branch
from
c5aaed7
to
b58ecba
Compare
JeffBezanson
force-pushed
the
jb/readuntilchomp
branch
from
b58ecba
to
7d3c538
Compare
|
The examples in the docstring show the old behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first (less important) commit just renames the existing
chompargument toreadlinetokeep, with the opposite meaning. The second commit adds thekeepoption toreaduntil, and makes the function exclude the delimiter by default, to matchreadline.Fixes #25633.