Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown terminal render: use box horizontal marker for admonitions, and color them depending on their title #25627

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Markdown terminal render: use box horizontal marker for admonitions, and color them depending on their title #25627

merged 1 commit into from
Jan 19, 2018

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented Jan 18, 2018 •
edited
Loading

(Also box-characters for footnotes and block quotes)

Previously:

screen shot 2018-01-18 at 15 29 09

PR:

screen shot 2018-01-18 at 15 25 49

@ararslan ararslan added stdlib:REPL Julia's REPL (Read Eval Print Loop) domain:display and printing Aesthetics and correctness of printed representations of objects. labels Jan 18, 2018
@ararslan
Copy link
Member

The 32-bit Windows failure is an unrelated permissions error, and the macOS build is unlikely to start any time in this century.

@KristofferC KristofferC merged commit fe80431 into master Jan 19, 2018
@fredrikekre fredrikekre deleted the kc/doc_admon_box branch January 19, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects. stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KristofferC @ararslan