Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow begin inside indexing #25614

Merged
merged 1 commit into from
Jan 18, 2018
Merged

disallow begin inside indexing #25614

merged 1 commit into from
Jan 18, 2018

Conversation

JeffBezanson
Copy link
Sponsor Member

part of #23354, #25458

@JeffBezanson JeffBezanson added parser Language parsing and surface syntax kind:deprecation This change introduces or involves a deprecation labels Jan 17, 2018
@stevengj stevengj added the needs tests Unit tests are required for this change label Jan 17, 2018
@stevengj
Copy link
Member

Looks good, except for the lack of a test.

@JeffBezanson
Copy link
Sponsor Member Author

I typically don't test deprecations.

@stevengj
Copy link
Member

Fair enough.

@stevengj stevengj removed the needs tests Unit tests are required for this change label Jan 17, 2018
@JeffBezanson JeffBezanson merged commit ae0a3e9 into master Jan 18, 2018
@JeffBezanson JeffBezanson deleted the jb/beginindex_syntax branch January 18, 2018 21:56
@stevengj stevengj mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:deprecation This change introduces or involves a deprecation parser Language parsing and surface syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffBezanson @stevengj