Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compiler as a test group #25593

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Add compiler as a test group #25593

merged 1 commit into from
Apr 4, 2018

Conversation

Keno
Copy link
Member

@Keno Keno commented Jan 16, 2018

For what the inference test used to be.

@Keno Keno requested a review from jrevels January 16, 2018 20:53
@ararslan ararslan added the test This change adds or pertains to unit tests label Jan 16, 2018
@StefanKarpinski
Copy link
Sponsor Member

There is already a compile test target so this naming seem potentially confusing.

@jrevels
Copy link
Member

jrevels commented Jan 17, 2018

There is already a compile test target so this naming seem potentially confusing.

Could change to basecompiler (i.e. "the part of the compiler that lives in Base"), which is what I've been using whenever it could be ambiguous

@StefanKarpinski
Copy link
Sponsor Member

We could add the compile tests to the compiler test suite.

@JeffBezanson
Copy link
Sponsor Member

The compile.jl test could be renamed precompile.jl, since that's mostly what it's about.

@StefanKarpinski
Copy link
Sponsor Member

How about renaming test/compile to test/precompile at the same time?

@vtjnash
test Makefile: add compiler as a test group
472d410 
For what the inference test used to be.

And rename `compile` test to `precompile`,
to reduce confusion over the similarity of their names.
@vtjnash vtjnash merged commit d7e6c16 into master Apr 4, 2018
@vtjnash vtjnash deleted the kf/compilertestgroup branch April 4, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@jrevels jrevels jrevels approved these changes

Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Keno @StefanKarpinski @jrevels @JeffBezanson @vtjnash @ararslan