Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate lexcmp, lexless; define cmp in terms of isless #25380

Merged
merged 2 commits into from
Jan 4, 2018
Merged

deprecate lexcmp, lexless; define cmp in terms of isless #25380

merged 2 commits into from
Jan 4, 2018

Conversation

JeffBezanson
Copy link
Sponsor Member

Fixes #5290.

@ararslan ararslan added the kind:deprecation This change introduces or involves a deprecation label Jan 4, 2018
StefanKarpinski
StefanKarpinski approved these changes Jan 4, 2018
View reviewed changes
Copy link
Sponsor Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you, @JeffBezanson

@StefanKarpinski StefanKarpinski merged commit 69f9c2e into master Jan 4, 2018
@StefanKarpinski StefanKarpinski deleted the jb/lexcmp branch January 4, 2018 15:41
JeffBezanson added a commit that referenced this pull request Jan 4, 2018
@JeffBezanson
update doc string for cmp after #25380
24c1140 
[ci skip]
ararslan pushed a commit that referenced this pull request Jan 5, 2018
@JeffBezanson @ararslan
update doc string for cmp after #25380 (#25390)
5953286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
kind:deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffBezanson @StefanKarpinski @ararslan