disallow pointer_from_objref on immutable values. fixes #15857
#25362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to date from before the representation of tuple types was changed in v0.4.
JeffBezanson
force-pushed
the
jb/pointer_from_objref
branch
2 times, most recently
from
8b93035
to
1434340
Compare
Keno
approved these changes
Jan 3, 2018
|
This seems stricter than necessary (we only might re-box isbits and unions thereof). Is that intentional for ensuring compatibility into v1.x? |
vtjnash
reviewed
Jan 3, 2018
| @@ -61,7 +61,7 @@ Ref(x::Ptr{T}, i::Integer) where {T} = x + (i - 1) * Core.sizeof(T) | |||
| function unsafe_convert(P::Type{Ptr{T}}, b::RefValue{T}) where T | |||
| if isbits(T) || isbitsunion(T) | |||
| return convert(P, pointer_from_objref(b)) | |||
| elseif _isleaftype(T) | |||
| elseif _isleaftype(T) && T.mutable | |||
There was a problem hiding this comment.
Surprisingly no, but can be fixed easily I think.
vtjnash
reviewed
Jan 3, 2018
| @test pointer_from_objref(b) == pointer_from_objref(b) | ||
| @test pointer_from_objref(b) != pointer_from_objref(b2) | ||
| @test pointer_from_objref(b) != pointer_from_objref(b3) | ||
| @test pointer_from_objref(b2) != pointer_from_objref(b3) |
There was a problem hiding this comment.
this is necessary to verify that the test is working. perhaps use the direct ccall version here?
Yes, and it also seems better to make the rule as simple as possible. If this is too annoying we can relax it later. |
JeffBezanson
force-pushed
the
jb/pointer_from_objref
branch
from
1434340
to
1502bd0
Compare
tkoolen
added a commit
to tkoolen/StaticArrays.jl
that referenced
this pull request
Jan 10, 2018
tkoolen
added a commit
to tkoolen/StaticArrays.jl
that referenced
this pull request
Jan 10, 2018
tkoolen
added a commit
to tkoolen/StaticArrays.jl
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.