Fix hash(::AbstractArray) failure in when some types support - and others do not #25250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hers do not The existing code only checked that subtraction was supported for the first two elements, but not for subsequent elements, which is necessary for heterogeneous arrays. Also fix a StackOverflow error due to the widen() fallback calling itself recursively by throwing a MethodError manually.
|
@StefanKarpinski Good to merge? |
StefanKarpinski
approved these changes
Jan 2, 2018
|
Ah yes, good to go, although probably needs a rebase and a fresh CI run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code (recently added by #16401) only checked that subtraction was supported for the first two elements, but not for subsequent elements, which is necessary for heterogeneous arrays.
Also fix a
StackOverflowerror due to thewidenfallback calling itself recursively by throwing aMethodErrormanually.