Document finalizer task-switch restriction #25141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could the hint about |
|
Sure, done. |
nstiurca
reviewed
Jul 17, 2018
| @@ -10,6 +10,10 @@ | |||
| Register a function `f(x)` to be called when there are no program-accessible references to | |||
| `x`, and return `x`. The type of `x` must be a `mutable struct`, otherwise the behavior of | |||
| this function is unpredictable. | |||
|
|
|||
| `f` must not cause a task switch, which excludes most I/O operations such as `println`. | |||
| `@schedule println("message")` or `ccall(:jl_, Void, (Any,), "message")` may be helpful for | |||
There was a problem hiding this comment.
It looks like @schedule is deprecated now, so the hint should probably be to use @async
|
Wow, thank you for documenting this, I had no idea |
|
I suppose |
samoconnor
added a commit
to JuliaLang/MbedTLS.jl
that referenced
this pull request
Nov 1, 2018
… IO related task switching. See JuliaLang/julia#25141 #181 (comment)
rened
pushed a commit
to contextflow/MbedTLS.jl
that referenced
this pull request
Jan 10, 2019
… IO related task switching. See JuliaLang/julia#25141 JuliaLang#181 (comment)
|
This is a pretty easy limitation to run into when debugging, and it's not obvious that IO task switching is the issue. Can this PR be merged? |
|
Had to ask about this on Slack, this should really be in the documentation by now |
|
I can no longer update the branch, so please feel free to edit/merge as you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #21442
and https://discourse.julialang.org/t/let-expression-and-garbage-collection/7804