Fix missing gc root in generator expansion #25123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClangSA complains:
```
/home/keno/julia/src/method.c:334:37: note: Passing non-rooted value as argument to function that may GC
func = (jl_code_info_t*)jl_expand((jl_value_t*)ex, linfo->def.method->module);
^ ~~~~~~~~~~~~~~~
```
But why you ask, `ex` is pushed into a gc frame earlier in the function. Well, because of C scoping rules,
that's a different `ex` than the one that gets assigned.
yuyichao
approved these changes
Dec 16, 2017
Keno
added a commit
that referenced
this pull request
Dec 16, 2017
```
/home/keno/julia/src/precompile.c:191:5: note: GC frame changed here
JL_GC_PUSH2(&p, &methsig);
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/keno/julia/src/precompile.c:193:5: note: Loop condition is true. Entering loop body
while (!incr) {
^
/home/keno/julia/src/precompile.c:194:24: note: Started tracking value here
jl_svec_t *p = jl_alloc_svec_uninit(l);
^~~~~~~~~~~~~~~~~~~~~~~
/home/keno/julia/src/precompile.c:195:9: note: Loop condition is true. Entering loop body
for (i = 0, idx_ctr = 0, incr = 1; i < l; i++) {
^
/home/keno/julia/src/precompile.c:197:13: note: Taking false branch
if (jl_is_uniontype(ty)) {
^
/home/keno/julia/src/precompile.c:195:9: note: Loop condition is false. Execution continues on line 217
for (i = 0, idx_ctr = 0, incr = 1; i < l; i++) {
^
/home/keno/julia/src/precompile.c:217:32: note: Passing non-rooted value as argument to function that may GC
methsig = (jl_value_t*)jl_apply_tuple_type(p);
^ ~
```
Essentially the same bug as #25123
Keno
added a commit
that referenced
this pull request
Dec 16, 2017
```
/home/keno/julia/src/precompile.c:191:5: note: GC frame changed here
JL_GC_PUSH2(&p, &methsig);
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/keno/julia/src/precompile.c:193:5: note: Loop condition is true. Entering loop body
while (!incr) {
^
/home/keno/julia/src/precompile.c:194:24: note: Started tracking value here
jl_svec_t *p = jl_alloc_svec_uninit(l);
^~~~~~~~~~~~~~~~~~~~~~~
/home/keno/julia/src/precompile.c:195:9: note: Loop condition is true. Entering loop body
for (i = 0, idx_ctr = 0, incr = 1; i < l; i++) {
^
/home/keno/julia/src/precompile.c:197:13: note: Taking false branch
if (jl_is_uniontype(ty)) {
^
/home/keno/julia/src/precompile.c:195:9: note: Loop condition is false. Execution continues on line 217
for (i = 0, idx_ctr = 0, incr = 1; i < l; i++) {
^
/home/keno/julia/src/precompile.c:217:32: note: Passing non-rooted value as argument to function that may GC
methsig = (jl_value_t*)jl_apply_tuple_type(p);
^ ~
```
Essentially the same bug as #25123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClangSA complains:
But why you ask,
exis pushed into a gc frame earlier in the function. Well, because of C scoping rules,that's a different
exthan the one that gets assigned.