Add doctest, missing import, refs, and stream -> io for multimedia #25000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
domain:docs
fredrikekre
reviewed
Dec 9, 2017
| @@ -15,7 +15,7 @@ export AbstractDisplay, display, pushdisplay, popdisplay, displayable, redisplay | |||
| # struct MIME{mime} end | |||
| # macro MIME_str(s) | |||
| import Base: MIME, @MIME_str | |||
|
|
|||
| import Base64 | |||
There was a problem hiding this comment.
Isn't this a bit weird? I thought we moved Base64 out because nothing in Base depend on it?
There was a problem hiding this comment.
I think stuff in Base depend on it (that's why it is in a bit weird place in sysimg.jl).
There was a problem hiding this comment.
Why is it needed here? For the doctests? Or is there a method in this file that the test don't cover?
|
There's a method (stringmime for binary mime types) which isn't covered by the tests.
|
|
Is this ok to go? Did I answer your question, @fredrikekre ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
base64encoding stuff forstringmimeneeds the import