Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render URL and name of Markdown links in terminal #24803

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Render URL and name of Markdown links in terminal #24803

merged 1 commit into from
Nov 28, 2017

Conversation

helgee
Copy link
Contributor

@helgee helgee commented Nov 27, 2017

Currently links in docstrings are rendered like this:

[Google](https://google.com) -> Google which makes them unusable from the terminal.

This PR changes this to:

[Google](https://google.com) -> Google (https://google.com)

@helgee helgee closed this Nov 27, 2017
@helgee helgee reopened this Nov 27, 2017
@helgee
Copy link
Contributor Author

helgee commented Nov 27, 2017

macOS and CircleCI failures are unrelated.

@KristofferC KristofferC merged commit 5d7ecf9 into JuliaLang:master Nov 28, 2017
@KristofferC KristofferC mentioned this pull request Nov 28, 2017
Closed
@helgee helgee deleted the terminal-md-links branch November 29, 2017 19:28
@KristofferC
Copy link
Sponsor Member

This should probably ignore @ref links.

@nalimilan
Copy link
Member

To give more context: @ref links now appear as (@ref), which is annoying and confusing.

@helgee helgee mentioned this pull request Dec 16, 2017
Merged
@helgee
Copy link
Contributor Author

helgee commented Dec 16, 2017

See #25132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@helgee @KristofferC @nalimilan @StefanKarpinski