Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More specific methods to replace join(args...) #24801

Merged
merged 2 commits into from
Nov 29, 2017
Merged

More specific methods to replace join(args...) #24801

merged 2 commits into from
Nov 29, 2017

Conversation

bramtayl
Copy link
Contributor

@bramtayl bramtayl commented Nov 27, 2017 •
edited
Loading

Fix #24433

@bramtayl bramtayl changed the title Fix #24433 More specific methods to replace join(args...) Nov 27, 2017
@bramtayl
Copy link
Contributor Author

Maybe backsport?

@bramtayl
Copy link
Contributor Author

Looks like the CI errors were due to #24782

@iblislin
Copy link
Member

It got fixed on master. please rebase :)

@rfourquet
Copy link
Member

Closing and re-opening should be enough?

@rfourquet rfourquet closed this Nov 27, 2017
@rfourquet rfourquet reopened this Nov 27, 2017
@KristofferC KristofferC reopened this Nov 27, 2017
@bramtayl
Copy link
Contributor Author

I think this looks good,. I'm not sure what to make of the error in wait(get_stdout) on mac, but I'm guessing its unrelated to join; I would expect a method error if it was.

@JeffBezanson JeffBezanson merged commit d184ef9 into JuliaLang:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bramtayl @iblislin @rfourquet @JeffBezanson @KristofferC