Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/file: remove fragile test case: test_22566 #24037

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Oct 7, 2017

I'm sorry that i wrote a fragile test case and it make bsd ci unstable :(

Still no idea why there is a race condition in this code, and slow machine (like bsd ci workers) is suffering from freezing.

@kshyatt kshyatt added the test This change adds or pertains to unit tests label Oct 7, 2017
@vtjnash
Copy link
Sponsor Member

vtjnash commented Oct 9, 2017

Are we sure this is actually the test that is not running? It's still a good test, maybe we should just disable it with a test for Sys.isbsd() && !Sys.isapple() for now?

@iblislin
Copy link
Member Author

iblislin commented Oct 9, 2017

e.g: the following build reports do not contain file testsuit.

And I had attached gdb to the process on my worker, found it is stop at ios.c 's open_cloexec. So I guess that there is a race condition between spawning fifo writer and reader.

The original goal of this test case is to ensure open_cloexec do not throw EINTR, but seems writing test case in Julia is not suitable for testing that low-level behaviour.

@kshyatt
Copy link
Contributor

kshyatt commented Oct 16, 2017

Do we want to merge this?

@iblislin
Copy link
Member Author

I can do Sys.isbsd() && !Sys.isapple() and look over the status of BSD CI.

@iblislin
Copy link
Member Author

dump?

Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean "bump?" :)

@iblislin
Copy link
Member Author

ha

@JeffBezanson JeffBezanson added the system:freebsd Affects only FreeBSD label Oct 31, 2017
@JeffBezanson JeffBezanson merged commit dab3954 into JuliaLang:master Oct 31, 2017
@iblislin
Copy link
Member Author

recent CI freeze is this

    frame #56: 0x0000000800a600b5 libjulia.so.0.7`start_task + 437 at task.c:268 [opt]
(lldb) p jl_lineno
(int) $0 = 1027
(lldb) p jl_filename
(const char *) $1 = 0x000000080d86b0d8 "/home/julia/ci/worker/11rel-amd64/build/test/file.jl"
(lldb) thread list
Process 85568 stopped
* thread #1: tid = 101577, 0x0000000802189498 libc.so.7`__sys_openat + 8
  thread #2: tid = 101161, 0x00000008021892ba libc.so.7`_sigwait + 10

that test case has similar structure with the test case disabled in this PR.

(the lldb info is from this build https://julia.iblis.cnmc.tw/#/builders/1/builds/5426

ararslan added a commit that referenced this pull request Jul 25, 2018
It was disabled in #24037 but reportedly seems to work okay when
isolated into this separate, node 1 only test group.
@iblislin iblislin deleted the test-file branch July 25, 2018 06:02
ararslan added a commit that referenced this pull request Jul 25, 2018
It was disabled in #24037 but reportedly seems to work okay when
isolated into this separate, node 1 only test group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:freebsd Affects only FreeBSD test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants