fix #15723, findfirst on strings
#23592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/fix15723
branch
from
908ead0
to
61e4a26
Compare
nalimilan
approved these changes
Sep 5, 2017
| @@ -379,3 +379,9 @@ end | |||
| @test rsearchindex("\U1f596\U1f596", "\U1f596\U1f596", endof("\U1f596\U1f596\U1f596")) == 1 | |||
|
|
|||
| @test_throws ErrorException "ab" ∈ "abc" | |||
|
|
|||
| # issue #15723 | |||
There was a problem hiding this comment.
Could be worth testing other cases for each function, e.g. with the searched character is in the middle of the string (with non-ASCII chars around it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes findfirst, findlast, findnext, and findprev more generic by using endof, nextind, and prevind. Also adds a
nextindmethod for arrays andCartesianIndex.These functions are scheduled for a refactoring, but in the meantime might as well make them work better.